3.0.0.9 SA Rule Description problems in the MailWatch web interface [with solutions]
Posted: 13 Apr 2016 08:41
I've noticed a minor problem with my installation that's finally bothered me enough to get off my ass and investigate it.
Problem 1: the Spam Assassin Rule Hits report does not display the full table
Examining the report HTML shows the full table is output, but the problem is in the SA rule description; specifically:
With the first entry, the <SPAN> is eaten by the browser resulting in the description looking like "Many tags embedded within text"
With the second, the table stops at the point this appears on the page.
Solution:
(a) change the descriptions, or
(b) html encode the <>'s that appear
Further Investigation:
change line 134 in rep_sa_rule_hits.php from:
to:
Changing the descriptions in local.cf also works, but that just avoids the problem.
Problem 2: the Spam Assassin Rule Hits report doesn't show all the descriptions
For example, in mine installation KAM_LAZY_DOMAIN_SECURITY shows no description. Running the "Update SpamAssassin Rule Descriptions" under Tools refreshes the description database, but KAM_LAZY_DOMAIN_SECURITY doesn't show up on that page. The rule does have a description defined in the KAM.cf
Workaround:
Add your own description lines into local.cf at the bottom of the file and reload the SpamAssassin Rule Description Update page.
Further Investigation:
I suspect the problem is in sa_rules_update.php, specifically line 66, but I've not yet had the chance to test to see if it actually goes wrong here.
Problem 1: the Spam Assassin Rule Hits report does not display the full table
Examining the report HTML shows the full table is output, but the problem is in the SA rule description; specifically:
Code: Select all
MANY_SPAN_IN_TEXT Many <SPAN> tags embedded within text
STYLE_GIBBERISH Nonsense in HTML <STYLE> tag
With the second, the table stops at the point this appears on the page.
Solution:
(a) change the descriptions, or
(b) html encode the <>'s that appear
Further Investigation:
change line 134 in rep_sa_rule_hits.php from:
Code: Select all
<TD>" . return_sa_rule_desc(strtoupper($key)) . "</TD>
Code: Select all
<TD>" . htmlentities(return_sa_rule_desc(strtoupper($key))) . "</TD>
Problem 2: the Spam Assassin Rule Hits report doesn't show all the descriptions
For example, in mine installation KAM_LAZY_DOMAIN_SECURITY shows no description. Running the "Update SpamAssassin Rule Descriptions" under Tools refreshes the description database, but KAM_LAZY_DOMAIN_SECURITY doesn't show up on that page. The rule does have a description defined in the KAM.cf
Workaround:
Add your own description lines into local.cf at the bottom of the file and reload the SpamAssassin Rule Description Update page.
Further Investigation:
I suspect the problem is in sa_rules_update.php, specifically line 66, but I've not yet had the chance to test to see if it actually goes wrong here.