Click Here to report links gone

Bugs in eFa 4
sharktech
Posts: 89
Joined: 14 Jan 2014 14:23

Click Here to report links gone

Post by sharktech »

Hi

Fresh install of V4 and i have no links for users to report SPAM anymore, can anyone help

TIA
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Click Here to report links gone

Post by shawniverson »

I am working on rebuilding this feature using PHP. Stay tuned! (This one is high on the list)
sharktech
Posts: 89
Joined: 14 Jan 2014 14:23

Re: Click Here to report links gone

Post by sharktech »

Much appreciated! :D
ItemsGmbH
Posts: 24
Joined: 20 Dec 2018 14:53

Re: Click Here to report links gone

Post by ItemsGmbH »

Hi there
Any progress?
AITCS
Posts: 45
Joined: 13 Mar 2017 11:12

Re: Click Here to report links gone

Post by AITCS »

Finally upgraded to v4 and just noticed this as well.
Wondering if I've missed something or this is still in the works.
Any updated information would be greatly appreciated.
w_bufffet
Posts: 12
Joined: 27 Mar 2016 15:32

Re: Click Here to report links gone

Post by w_bufffet »

Any update on this?
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Click Here to report links gone

Post by shawniverson »

Still in the works. The releasing part is done, just need to finish the reporting part.
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

Hello,

can I do anything to accelerate this a litte bit?
We are still running on v3 because of this feature and now with the turn of the year let's encrypt isn't working anymore.
So we have to migrate to v4 within the next 2 months ...

Sincerely,
Ulrich.
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Click Here to report links gone

Post by shawniverson »

Sure can. I'll bump this to the top of my list.
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

Hello shawn,

many thanks!!!!
I made a donation too, hope this also helps ;)


Sincerely,
Ulrich.
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Click Here to report links gone

Post by shawniverson »

freyuh wrote: 18 Jan 2022 15:58 Hello shawn,

many thanks!!!!
I made a donation too, hope this also helps ;)


Sincerely,
Ulrich.
Thank you so much! :D
hawrebelo
Posts: 1
Joined: 06 Mar 2022 09:13

Re: Click Here to report links gone

Post by hawrebelo »

keep in touch with progress
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Click Here to report links gone

Post by shawniverson »

Report link is back in 4.0.4-32:

You will find the configuration options under 8) Spam Settings in eFa-Configure.

Options to control the report link:

1) Non Spam Settings
8) Trusted Networks
9) Inline Signature Rules
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

Thank you very much Shawn
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

/var/eFa/lib/eFa-Configure/func_asknonspam: touch /etc/MailScanner/rules/inline.sig.txt.rules

I think this should be /etc/MailScanner/rules/inline.sig.text.rules
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Click Here to report links gone

Post by shawniverson »

Thanks, I'll get this corrected.
forhire
Posts: 30
Joined: 10 Jun 2021 16:54

Re: Click Here to report links gone

Post by forhire »

shawniverson wrote: 12 Mar 2022 17:46 Report link is back in 4.0.4-32:
Shawn, I have enabled inline signature but mailscanner isn't inserting the signature. Any ideas?
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

Have you edited the inline sig rules?
forhire
Posts: 30
Joined: 10 Jun 2021 16:54

Re: Click Here to report links gone

Post by forhire »

freyuh wrote: 01 May 2022 17:48 Have you edited the inline sig rules?
When I added mydomain.com, it inserted rules into these files.

sudo grep mydomain.com /etc/MailScanner/rules/*
/etc/MailScanner/rules/inline.sig.html.rules:To: *@mydomain.com /etc/MailScanner/reports/en/inline.sig.html
/etc/MailScanner/rules/inline.sig.text.rules:To: *@mydomain.com /etc/MailScanner/reports/en/inline.sig.txt

Both includes exist and contain a signature.
/etc/MailScanner/reports/en/inline.sig.html
/etc/MailScanner/reports/en/inline.sig.txt

It appears it should be working. When it appends the inline sig is it logged someplace? I didn't find anything obvious.
forhire
Posts: 30
Joined: 10 Jun 2021 16:54

Re: Click Here to report links gone

Post by forhire »

After I Enabled it under option 1) Non Spam Settings I have it appending to ALL domains. Not just the domains appearing in the rules.

Mailscanner.conf shows it's using custom(nonspam) as the spam action:
Sign Clean Messages = No
Non Spam Actions = store deliver header "X-Spam-Status:No" custom(nonspam)

It's acting as if Sign Clean Messages = Yes yet I have confirmed it is No. It appears custom(nonspam) is the issue. Rebooting the server doesn't correct the issue.

Any ideas?
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

I have to take a look at it ...
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

I think the evaluation of the rules is missing in the custom function.
The logic for that has to be implemented ...
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Click Here to report links gone

Post by shawniverson »

custom(nonspam) overrides the Sign Clean Messages to add extra variables.

Do you have the following in MailScanner.conf

Code: Select all

Inline HTML Signature = %rules-dir%/inline.sig.html.rules
Inline Text Signature = %rules-dir%/inline.sig.text.rules
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

Yes I (we) have.
But the signature is nevertheless attached to the email.

And you have a small error in the file CustomAction.pm:

Code: Select all

    } elsif ($file =~ /inline.sig.in.txt/ && $spamwhitelisted eq "1") {
should be

Code: Select all

   } elsif ($file =~ /inline.sig.txt/ && $spamwhitelisted eq "1") {
freyuh
Posts: 62
Joined: 04 Oct 2018 11:21

Re: Click Here to report links gone

Post by freyuh »

But the signature is nevertheless attached to the email.
And I recognize this, because the english report is attached instead of the configured german ...
Post Reply