Page 1 of 2

Click Here to report links gone

Posted: 20 Nov 2019 11:51
by sharktech
Hi

Fresh install of V4 and i have no links for users to report SPAM anymore, can anyone help

TIA

Re: Click Here to report links gone

Posted: 20 Nov 2019 13:25
by shawniverson
I am working on rebuilding this feature using PHP. Stay tuned! (This one is high on the list)

Re: Click Here to report links gone

Posted: 20 Nov 2019 14:35
by sharktech
Much appreciated! :D

Re: Click Here to report links gone

Posted: 26 Feb 2020 10:26
by ItemsGmbH
Hi there
Any progress?

Re: Click Here to report links gone

Posted: 03 Oct 2021 11:17
by AITCS
Finally upgraded to v4 and just noticed this as well.
Wondering if I've missed something or this is still in the works.
Any updated information would be greatly appreciated.

Re: Click Here to report links gone

Posted: 03 Jan 2022 09:01
by w_bufffet
Any update on this?

Re: Click Here to report links gone

Posted: 06 Jan 2022 14:55
by shawniverson
Still in the works. The releasing part is done, just need to finish the reporting part.

Re: Click Here to report links gone

Posted: 17 Jan 2022 10:51
by freyuh
Hello,

can I do anything to accelerate this a litte bit?
We are still running on v3 because of this feature and now with the turn of the year let's encrypt isn't working anymore.
So we have to migrate to v4 within the next 2 months ...

Sincerely,
Ulrich.

Re: Click Here to report links gone

Posted: 17 Jan 2022 19:55
by shawniverson
Sure can. I'll bump this to the top of my list.

Re: Click Here to report links gone

Posted: 18 Jan 2022 15:58
by freyuh
Hello shawn,

many thanks!!!!
I made a donation too, hope this also helps ;)


Sincerely,
Ulrich.

Re: Click Here to report links gone

Posted: 23 Jan 2022 17:12
by shawniverson
freyuh wrote: 18 Jan 2022 15:58 Hello shawn,

many thanks!!!!
I made a donation too, hope this also helps ;)


Sincerely,
Ulrich.
Thank you so much! :D

Re: Click Here to report links gone

Posted: 06 Mar 2022 09:15
by hawrebelo
keep in touch with progress

Re: Click Here to report links gone

Posted: 12 Mar 2022 17:46
by shawniverson
Report link is back in 4.0.4-32:

You will find the configuration options under 8) Spam Settings in eFa-Configure.

Options to control the report link:

1) Non Spam Settings
8) Trusted Networks
9) Inline Signature Rules

Re: Click Here to report links gone

Posted: 13 Mar 2022 09:05
by freyuh
Thank you very much Shawn

Re: Click Here to report links gone

Posted: 14 Mar 2022 11:52
by freyuh
/var/eFa/lib/eFa-Configure/func_asknonspam: touch /etc/MailScanner/rules/inline.sig.txt.rules

I think this should be /etc/MailScanner/rules/inline.sig.text.rules

Re: Click Here to report links gone

Posted: 15 Mar 2022 02:05
by shawniverson
Thanks, I'll get this corrected.

Re: Click Here to report links gone

Posted: 01 May 2022 17:11
by forhire
shawniverson wrote: 12 Mar 2022 17:46 Report link is back in 4.0.4-32:
Shawn, I have enabled inline signature but mailscanner isn't inserting the signature. Any ideas?

Re: Click Here to report links gone

Posted: 01 May 2022 17:48
by freyuh
Have you edited the inline sig rules?

Re: Click Here to report links gone

Posted: 02 May 2022 01:15
by forhire
freyuh wrote: 01 May 2022 17:48 Have you edited the inline sig rules?
When I added mydomain.com, it inserted rules into these files.

sudo grep mydomain.com /etc/MailScanner/rules/*
/etc/MailScanner/rules/inline.sig.html.rules:To: *@mydomain.com /etc/MailScanner/reports/en/inline.sig.html
/etc/MailScanner/rules/inline.sig.text.rules:To: *@mydomain.com /etc/MailScanner/reports/en/inline.sig.txt

Both includes exist and contain a signature.
/etc/MailScanner/reports/en/inline.sig.html
/etc/MailScanner/reports/en/inline.sig.txt

It appears it should be working. When it appends the inline sig is it logged someplace? I didn't find anything obvious.

Re: Click Here to report links gone

Posted: 02 May 2022 03:34
by forhire
After I Enabled it under option 1) Non Spam Settings I have it appending to ALL domains. Not just the domains appearing in the rules.

Mailscanner.conf shows it's using custom(nonspam) as the spam action:
Sign Clean Messages = No
Non Spam Actions = store deliver header "X-Spam-Status:No" custom(nonspam)

It's acting as if Sign Clean Messages = Yes yet I have confirmed it is No. It appears custom(nonspam) is the issue. Rebooting the server doesn't correct the issue.

Any ideas?

Re: Click Here to report links gone

Posted: 02 May 2022 06:56
by freyuh
I have to take a look at it ...

Re: Click Here to report links gone

Posted: 02 May 2022 12:43
by freyuh
I think the evaluation of the rules is missing in the custom function.
The logic for that has to be implemented ...

Re: Click Here to report links gone

Posted: 02 May 2022 14:52
by shawniverson
custom(nonspam) overrides the Sign Clean Messages to add extra variables.

Do you have the following in MailScanner.conf

Code: Select all

Inline HTML Signature = %rules-dir%/inline.sig.html.rules
Inline Text Signature = %rules-dir%/inline.sig.text.rules

Re: Click Here to report links gone

Posted: 02 May 2022 15:03
by freyuh
Yes I (we) have.
But the signature is nevertheless attached to the email.

And you have a small error in the file CustomAction.pm:

Code: Select all

    } elsif ($file =~ /inline.sig.in.txt/ && $spamwhitelisted eq "1") {
should be

Code: Select all

   } elsif ($file =~ /inline.sig.txt/ && $spamwhitelisted eq "1") {

Re: Click Here to report links gone

Posted: 02 May 2022 15:07
by freyuh
But the signature is nevertheless attached to the email.
And I recognize this, because the english report is attached instead of the configured german ...