Error in viewmail.php

Report bugs and workarounds
Post Reply
Odon Garma
Posts: 33
Joined: 08 May 2017 14:10

Error in viewmail.php

Post by Odon Garma »

Line 184 and Line 235:

Code: Select all

($message->virusinfected === 0 && $message->nameinfected === 0 && $message->otherinfected === 0) ||
$_SESSION['user_type'] === 'A' ||
(defined('DOMAINADMIN_CAN_SEE_DANGEROUS_CONTENTS') && true === DOMAINADMIN_CAN_SEE_DANGEROUS_CONTENTS && $_SESSION['user_type'] === 'D')

virusinfected is Type String, so === 0 is always false

shoud be ($message->virusinfected === '0' && ....

The bad result is: normal users can not release spam messages

This bug is since 3.0.1.9 and still in 3.0.2.2

Greetz
User avatar
shawniverson
Posts: 3644
Joined: 13 Jan 2014 23:30
Location: Indianapolis, Indiana USA
Contact:

Re: Error in viewmail.php

Post by shawniverson »

Post Reply